Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): render empty state #1532

Merged
merged 2 commits into from
Dec 24, 2021
Merged

fix(heatmap): render empty state #1532

merged 2 commits into from
Dec 24, 2021

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Dec 21, 2021 •
edited
Loading

Summary

This PR introduces the handling for empty state (no data) in heatmap. You can use the Settings.noResults to show your own custom component

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@markov00 markov00 changed the title Fix empty state fix(heatmap): render empty state Dec 21, 2021
@markov00 markov00 force-pushed the 2021_12_21-fix_heatmap_no_results branch from 84715fa to ae3c1cf Compare December 24, 2021 09:42
@markov00 markov00 added :data Data/series/scales related issue :heatmap Heatmap/Swimlane chart related issue enhancement New feature or request labels Dec 24, 2021
@markov00 markov00 marked this pull request as ready for review December 24, 2021 13:45
@markov00 markov00 merged commit 59002df into elastic:master Dec 24, 2021
@markov00 markov00 deleted the 2021_12_21-fix_heatmap_no_results branch December 24, 2021 14:02
nickofthyme pushed a commit that referenced this pull request Jan 5, 2022
@semantic-release-bot @markov00
chore(release): 42.0.0 [skip ci]
d6e6c18 
# [42.0.0](v41.0.1...v42.0.0) (2022-01-05)

### Bug Fixes

* **flamegraph:** solve animation regression occurring with 6db2677 ([#1541](#1541)) ([5ec6037](5ec6037)), closes [#1540](#1540)
* **heatmap:** render empty state ([#1532](#1532)) ([59002df](59002df))
* **waffle:** fix strange 0 text in legend item extra when label is 0 ([#1538](#1538)) ([72224b9](72224b9))

### Features

* **goal:** add valueFormatter for tooltip ([#1529](#1529)) ([8139973](8139973))
* **heatmap:** add axis titles ([#1503](#1503)) ([a87325d](a87325d))
* **types:** improve generic types in specs, and spec prop types ([#1421](#1421)) ([562929e](562929e))

### BREAKING CHANGES

* **types:** The `xAccessor` and `yAccessor` are now required on all xy chart specs. Stronger typing on `data` prop that may cause type errors when using untyped array (i.e. `const arr: never[] = []`). Other minor type changes related to spec types.
* **heatmap:** The heatmap yAxisLabel.padding style type is changed from Pixel | Partial<Padding> to Pixels | Padding. The heatmap axis labels are now correctly subjected to padding calculations and it will result in a slightly different position of labels.

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monfera monfera monfera approved these changes

Assignees
No one assigned
Labels
:data Data/series/scales related issue enhancement New feature or request :heatmap Heatmap/Swimlane chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markov00 @monfera