-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: flail to attempt to fix dependabot updates for examples/ dir #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot updates of the examples dir has been warning recently with: updater | 2024/09/30 01:28:04 WARN <job_892539850> Please check your configuration as there are groups where no dependencies match: - examples This can happen if: - the group's 'pattern' rules are misspelled - your configuration's 'allow' rules do not permit any of the dependencies that match the group - the dependencies that match the group rules have been removed from your project
david-luna
approved these changes
Oct 1, 2024
This was a vain attempt. It didn't help: https://github.com/elastic/elastic-otel-node/actions/runs/11130803300/job/30930944527
|
trentm
added a commit
that referenced
this pull request
Oct 1, 2024
…es/ dir This time we'll remove the grouping to see if that helps. We would *like* dependabot updates for examples/ to all be in a single group, but that isn't working, so we'll take separate update PRs instead if that works. Refs: #384 (flail attempt 1)
trentm
added a commit
that referenced
this pull request
Oct 1, 2024
…es/ dir This time we'll remove the relative dep, on the theory that it is tripping up dependabot. Keeping it this way puts a burden on the developer that wants to test exapmles with local changes. Perhaps that is fine for now. Arguably though this is the tail wagging the dog. Refs: #384 (flail attempt 1) Refs: #386 (flail attempt 2)
trentm
added a commit
that referenced
this pull request
Oct 2, 2024
…es/ dir (#387) This time we'll remove the relative dep, on the theory that it is tripping up dependabot. Keeping it this way puts a burden on the developer that wants to test exapmles with local changes. Perhaps that is fine for now. Arguably though this is the tail wagging the dog. Refs: #384 (flail attempt 1) Refs: #386 (flail attempt 2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot updates of the examples dir has been warning recently with: