chore: Slack notifications for issue/PR open/close actions #496
+118
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing this as an alternative to the issue and PR Slack
notifications we currently get from https://github.com/integrations/slack
because of the following issues with that integration:
other conversation in the channel. This lowers the signal-to-noise
ratio in the channel, which discourages meaningful conversation.
idea for a repo with commonly simple and short issue/PR
descriptions. However, in general it is just spam. It can also get
silly for PRs that have large
<details>
blocks, which the Slackrendering doesn't hide. E.g. deps: Bump updatecli version to v0.89.0 opbeans-node#304
("Comment", "Close").
This sounds nice, but it results in dynamic-height content in the
chat area that discourages ongoing conversation.
to find. We have these notifications for 4+ repos, so it is pain to have
to hunt for that.
@-
names people listed as reviewers for PRs and makes a threadsof every PR to show when it is merged. This sounds like a nice idea,
but in practice means that the "Threads" section of Slack is spammed
with useless unread threads for merged PRs that I've reviewed.
chat-ops thingy, and I don't want the noise. I want higher signal.
dependabot/renovate PRs. Currently we have those scheduled for Sunday.
Every Monday morning is a multi-page scroll of useless notifications
about regular dependabot maintenance work. It is very easy to lose
meaningful conversation from Friday or over the weekend in that
noise.
I propose to discuss this, try it out. Then if we prefer it, we stop the issue and PR notifications from the existing GH/Slack integration (we can keep its notifications for some other things like unfurling links to GH issues/comments/code-ranges). And then we do this for the other repos we care about.
FWIW, at least the ignoring of dependabot/renovate PR notifications has been frequently requested of the Slakc integration (since 2019), but not supported: integrations/slack#951
There was a PR to implement something that would work for that, but it was never accepted.