Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow event types that are allowed by any of the categories in the document #1011

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

jsoriano
Copy link
Member

This change relaxes the validation of event types for fields whose allowed values include a set of accepted event types:

  • Any event type is valid if it is valid for any of the values. Before it should be valid for all values.
  • Empty event types are allowed.

Follow-up of #837, #961.

…cument

This change relaxes the validation of event types for fields whose
allowed values include a set of accepted event types:
- Any event type is valid if it is valid for any of the values. Before
  it should be valid for all values.
- Empty event types are allowed.
@jsoriano jsoriano requested review from andrewkroh, P1llus and a team October 19, 2022 15:24
@jsoriano jsoriano self-assigned this Oct 19, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-19T15:24:52.619+0000

  • Duration: 34 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 854
Skipped 0
Total 854

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 66.667% (86/129) 👍
Classes 61.413% (113/184) 👍
Methods 47.52% (364/766) 👍 0.069
Lines 30.749% (3292/10706) 👍 0.115
Conditionals 100.0% (0/0) 💚

@jsoriano jsoriano merged commit f64edaa into elastic:main Oct 20, 2022
@jsoriano jsoriano deleted the event-category-multiple-values branch October 20, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants