Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override ECS objects to group or nested #1493

Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 6, 2023

Package Spec v3 is more strict with the validation of objects. They
cannot be used now just to group fields, as is done in ECS.

When it is used only to group fields, the developers needs to decide
if it should be interpreted by Fleet as a group, so no mapping is installed
for the field itself, but for its subfields, or as a nested, so the object
is installed as nested, usually intended for arrays of objects.

Needed for elastic/integrations#8115.

@jsoriano jsoriano self-assigned this Oct 6, 2023
@jsoriano jsoriano requested a review from a team October 6, 2023 14:36
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @jsoriano

@jsoriano jsoriano merged commit cc1fe2d into elastic:main Oct 6, 2023
1 check passed
@jsoriano jsoriano deleted the allow-override-object-to-nested-group branch October 6, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants