Add flag to enable logsdb mode in logs data streams #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
Jul 3, 2024
ruflin
reviewed
Jul 3, 2024
…applies to the data stream
|
As discussed internally, we need to disable validation for normalized fields when logsdb is used, because it is going to use synthetic mode. In fd68bfc I have refactored our detection of synthetics mode to be based on the simulated index template for the data stream, instead of using the component template provided by the package. |
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
👍
Checked that it reports what it is expected in two different packages:
- (synthetic test package) synthetic enabled: https://buildkite.com/elastic/elastic-package/builds/3541#0190779f-4c8b-4063-8999-f4b5c3ba512d/193-2385
- (nginx test package) synthetic disabled: https://buildkite.com/elastic/elastic-package/builds/3541#0190779f-4cae-43dd-aa64-cdb512a97132/195-855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new profile parameter,
stack.logsdb_enabled, to enable the feature flag that enables the logs index mode in all logs data streams (elastic/elasticsearch#108762), in stacks that support it.This can be tested now with the 8.15 snapshots, for example:
Closes #1842.