Skip to content

Commit

Permalink
Can not upgrade kuromoji plugin from elasticsearch 0.90.5
Browse files Browse the repository at this point in the history
Due to fix [3790](elastic/elasticsearch#3790) in core, upgrading an analyzer provided as a plugin now fails.

See elastic/elasticsearch#5030 for details.

Issue is in elasticsearch core code but can be fixed in plugins by overloading `PreBuiltAnalyzerProviderFactory`,  `PreBuiltTokenFilterFactoryFactory`, `PreBuiltTokenizerFactoryFactory` or `PreBuiltCharFilterFactoryFactory ` when used.

Closes #21
  • Loading branch information
dadoonet committed Feb 28, 2014
1 parent a3246a2 commit 3401c21
Show file tree
Hide file tree
Showing 4 changed files with 120 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public KuromojiIndicesAnalysis(Settings settings,
super(settings);

indicesAnalysisService.charFilterFactories().put("kuromoji_iteration_mark",
new PreBuiltCharFilterFactoryFactory(new CharFilterFactory() {
new KurumojiCharFilterFactoryFactory(new CharFilterFactory() {
@Override
public String name() {
return "kuromoji_iteration_mark";
Expand All @@ -58,7 +58,7 @@ public Reader create(Reader reader) {
}));

indicesAnalysisService.tokenizerFactories().put("kuromoji_tokenizer",
new PreBuiltTokenizerFactoryFactory(new TokenizerFactory() {
new KurumojiTokenizerFactoryFactory(new TokenizerFactory() {
@Override
public String name() {
return "kuromoji_tokenizer";
Expand All @@ -72,7 +72,7 @@ public Tokenizer create(Reader reader) {
}));

indicesAnalysisService.tokenFilterFactories().put("kuromoji_baseform",
new PreBuiltTokenFilterFactoryFactory(new TokenFilterFactory() {
new KurumojiTokenFilterFactoryFactory(new TokenFilterFactory() {
@Override
public String name() {
return "kuromoji_baseform";
Expand All @@ -86,7 +86,7 @@ public TokenStream create(TokenStream tokenStream) {

indicesAnalysisService.tokenFilterFactories().put(
"kuromoji_part_of_speech",
new PreBuiltTokenFilterFactoryFactory(new TokenFilterFactory() {
new KurumojiTokenFilterFactoryFactory(new TokenFilterFactory() {
@Override
public String name() {
return "kuromoji_part_of_speech";
Expand All @@ -102,7 +102,7 @@ public TokenStream create(TokenStream tokenStream) {

indicesAnalysisService.tokenFilterFactories().put(
"kuromoji_readingform",
new PreBuiltTokenFilterFactoryFactory(new TokenFilterFactory() {
new KurumojiTokenFilterFactoryFactory(new TokenFilterFactory() {
@Override
public String name() {
return "kuromoji_readingform";
Expand All @@ -115,7 +115,7 @@ public TokenStream create(TokenStream tokenStream) {
}));

indicesAnalysisService.tokenFilterFactories().put("kuromoji_stemmer",
new PreBuiltTokenFilterFactoryFactory(new TokenFilterFactory() {
new KurumojiTokenFilterFactoryFactory(new TokenFilterFactory() {
@Override
public String name() {
return "kuromoji_stemmer";
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to Elasticsearch (the "Author") under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. Author licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.elasticsearch.indices.analysis;

import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.index.analysis.CharFilterFactory;
import org.elasticsearch.index.analysis.PreBuiltCharFilterFactoryFactory;

public class KurumojiCharFilterFactoryFactory extends PreBuiltCharFilterFactoryFactory {
private final CharFilterFactory charFilterFactory;

public KurumojiCharFilterFactoryFactory(CharFilterFactory charFilterFactory) {
super(charFilterFactory);
this.charFilterFactory = charFilterFactory;
}

@Override
public CharFilterFactory create(String name, Settings settings) {
return charFilterFactory;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to Elasticsearch (the "Author") under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. Author licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.elasticsearch.indices.analysis;

import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.index.analysis.PreBuiltTokenFilterFactoryFactory;
import org.elasticsearch.index.analysis.TokenFilterFactory;

public class KurumojiTokenFilterFactoryFactory extends PreBuiltTokenFilterFactoryFactory {
private final TokenFilterFactory tokenFilterFactory;

public KurumojiTokenFilterFactoryFactory(TokenFilterFactory tokenFilterFactory) {
super(tokenFilterFactory);
this.tokenFilterFactory = tokenFilterFactory;
}

@Override
public TokenFilterFactory create(String name, Settings settings) {
return tokenFilterFactory;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Licensed to Elasticsearch (the "Author") under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. Author licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.elasticsearch.indices.analysis;

import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.index.analysis.PreBuiltTokenizerFactoryFactory;
import org.elasticsearch.index.analysis.TokenizerFactory;

public class KurumojiTokenizerFactoryFactory extends PreBuiltTokenizerFactoryFactory {
private final TokenizerFactory tokenizerFactory;

public KurumojiTokenizerFactoryFactory(TokenizerFactory tokenizerFactory) {
super(tokenizerFactory);
this.tokenizerFactory = tokenizerFactory;
}

@Override
public TokenizerFactory create(String name, Settings settings) {
return tokenizerFactory;
}
}

0 comments on commit 3401c21

Please sign in to comment.