Use Azure Java Management SDK 0.7.0 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storage and Management settings are not related in Azure API.
We were using the following convention for storage specific settings:
```yml
cloud:
azure:
storage_account: your_azure_storage_account
storage_key: your_azure_storage_key
```
A better naming (and Java packaging) would be by moving `storage` settings in their own package
`cloud.azure.storage`:
```yml
cloud:
azure:
storage:
account: your_azure_storage_account
key: your_azure_storage_key
```
Note that we can still read deprecated settings but it will print a `WARN` with an advice to make sure users don't forget to move.
Azure Java SDK follows some conventions about property names and we can use the same convention. The benefit is that it makes the code cleaner and easier to understand as components settings relies on package name without the `org.elasticsearch` prefix. In previous versions, we defined: ``` cloud: azure: keystore: /path/to/keystore password: your_password_for_keystore subscription_id: your_azure_subscription_id service_name: your_azure_cloud_service_name port_name: elasticsearch host_type: private_ip ``` We now define: ``` cloud: azure: management: keystore: path: /path/to/keystore password: your_password_for_keystore subscription: id: your_azure_subscription_id cloud: service: name: your_azure_cloud_service_name discovery: azure: host: type: private_ip endpoint: name: elasticsearch ``` The following are a list of settings (prefixed with `cloud.azure.management`) that can further control the discovery: * `keystore.path`: /path/to/keystore * `keystore.password`: your_password for the keystore * `subscription.id`: your_azure_subscription_id * `cloud.service.name`: your_azure_cloud_service_name So basically we deprecate the following properties: * `cloud.azure.keystore` to `cloud.azure.management.keystore.path` * `cloud.azure.password` to `cloud.azure.management.keystore.password` * `cloud.azure.subscription_id` to `cloud.azure.management.subscription.id` * `cloud.azure.service_name` to `cloud.azure.management.cloud.service.name` * `cloud.azure.port_name` to `discovery.azure.port.name` * `cloud.azure.host_type` to `discovery.azure.host.type` Note that we can still read deprecated settings but it will print a `WARN` with an advice to make sure users don't forget to move.
This first version adds `azure-management` 0.7.0 instead of using our own XML implementation. We can now have more control and give more options to the users. We now support different keystore types using `cloud.azure.management.keystore.type`: * `pkcs12` * `jceks` * `jks` Closes elastic#38
dadoonet
force-pushed
the
pr/azure-sdk-0.7.0
branch
from
f8c5772
to
6eeb81e
Compare
This was referenced Feb 16, 2015
Closed
|
This PR is included in #64. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to PR #61 and #62, this version adds
azure-management0.7.0 instead of using our own XML implementation.We can now have more control and give more options to the users.
Closes #38