This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
Fix node name logging #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In upstream Elasticsearch we have modified how the node name is logged. This commit makes the logging configuration in the Docker image consistent with this change.
|
Relates elastic/elasticsearch#31588 |
|
Do we have an extra space in the builtin pattern? I *thought* we did but
I'm on mobile now.
…On Sat, Nov 17, 2018, 20:14 Jason Tedor ***@***.*** wrote:
@jasontedor <https://github.com/jasontedor> requested your review on: #217
<#217> Fix node name
logging.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLos8nf4MCZtqe8xFHp-5jDDo7TCH6ks5uwLRogaJpZM4YnuX8>
.
|
|
Lgtm then. Thanks for the link!
…On Sat, Nov 17, 2018, 20:43 Jason Tedor ***@***.*** wrote:
Nope. See:
https://github.com/elastic/elasticsearch/blob/v6.5.0/distribution/src/config/log4j2.properties
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLompJPUy8Un8hac4ixGD9G65ehjAZks5uwLslgaJpZM4YnuX8>
.
|
jasontedor
commented
Nov 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upstream Elasticsearch we have modified how the node name is logged. This commit makes the logging configuration in the Docker image consistent with this change.