use docker healthcheck #27
Conversation
|
Can one of the admins verify this patch? |
4 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Thanks for your interest and the PR! The trouble with this approach is that curl requests will fail as x-pack (inc. security) is included in the Elasticsearch image and thus those API calls require authentication. So for that to work we'd need to tweak the default x-pack configuration and allow anonymous access specifically to a chosen health check endpoint (e.g. Additionally, for every new feature added, we need acceptance tests, so we'll need to add python tests to ensure this is working as expected. Incidentally, I just tried |
|
You're right about the authorization issue with xpack. I did not face it because I was just overriding the configuration with one that doesn't use xpack. What do you suggest as next steps for this PR? |
| host="$(hostname -i || echo '127.0.0.1')" | ||
|
|
||
| # TODO with xpack, the below curl will fail with "unauthorized" error if xpack is enabled | ||
| if health="$(curl -fsSL "http://$host:9200/_cat/health?h=status")"; then |
There was a problem hiding this comment.
even if you get a 401/403 response code, this means container is healthy
you could call curl -I -X "http://$host:9200" and parse response code
|
Closing this based on the argumentation in #60 |
This PR adds support for healthcheck in the
docker-composefile.ATM, your repo's tester has a built-in
wait for health checkintests/es_acceptance.pyin functionwait_for_cluster_health. Using docker's healthcheck, other services can benefit from this without having to re-code await for health checkfunction in each. On the down-side, this requires upgrading theymlversion from2.0to2.1, and hence upgradingdocker-composeanddockerto versions supporting itdocker infooutput: (1.13.1) http://paste.ubuntu.com/24039459/docker-composeversion:docker-compose version 1.11.1, build 7c5d5e4Maybe creating a separate branch for this would be convenient?
Note that I ran
makefor testing and it failed with aconnection failederror, but then again I ranmakeon master, and it also failed.