minor typing updates

elastic · Oct 18, 2024 · 118ff63 · 118ff63
1 parent c43c5e3
commit 118ff63
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/elasticsearch_dsl/document_base.py b/elasticsearch_dsl/document_base.py
@@ -165,7 +165,7 @@ def __init__(self, name: str, bases: Tuple[type, ...], attrs: Dict[str, Any]):
         fields.update(annotations.keys())
         field_defaults = {}
         for name in fields:
-            value = None
+            value: Any = None
             required = None
             multi = None
             if name in annotations:
@@ -201,7 +201,7 @@ def __init__(self, name: str, bases: Tuple[type, ...], attrs: Dict[str, Any]):
                     field_args = [type_]
                 elif type_ in self.type_annotation_map:
                     # use best field type for the type hint provided
-                    field, field_kwargs = self.type_annotation_map[type_]
+                    field, field_kwargs = self.type_annotation_map[type_]  # type: ignore
 
                 if field:
                     field_kwargs = {

diff --git a/utils/generator.py b/utils/generator.py
@@ -99,15 +99,6 @@ def add_not_set(type_):
     return type_
 
 
-# def add_optional(type_):
-#     """Add Optional to a Python type hint."""
-#     if type_.startswith("Union["):
-#         type_ = f"{type_[:-1]}, None]"
-#     else:
-#         type_ = f"Union[{type_}, None]"
-#     return type_
-
-
 class ElasticsearchSchema:
     """Operations related to the Elasticsearch schema."""
 

diff --git a/utils/templates/response.__init__.py.tpl b/utils/templates/response.__init__.py.tpl
@@ -193,7 +193,7 @@ class AggResponse(AttrDict[Any], Generic[_R]):
 
 
 class UpdateByQueryResponse(AttrDict[Any], Generic[_R]):
-    """An Elasticsearch response.
+    """An Elasticsearch update by query response.
 
     {% for arg in ubq_response.args %}
         {% for line in arg.doc %}