-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type annotations #1533
Comments
This would be incredibly useful for the Elasticsearch DSL, as it would mean truly type-safe access to Elasticsearch from Python! |
Ideally, the package should then also be declared as a PEP 561 compliant stub package. |
Hello! As the new maintainer, I am in favor of adding types, but do not want one huge pull request. Instead, it should be done incrementally, as described in https://sethmlarson.dev/tests-arent-enough-case-study-after-adding-types-to-urllib3. I will be happy to review small pull requests, adding types to small files first. Thanks! |
This is going to be out with the 8.15 release. |
Hi!
Adding type annotations to this library would allow for better auto complete and type checking with tools like mypy and pyright.
Would you accept a PR that adds type annotations?
The text was updated successfully, but these errors were encountered: