Removed __orig_class__ attribute out of AttrDict instances
#1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
filter-orig-class-attribute
branch
from
1c69cd1 to
e5c4556
Compare
miguelgrinberg
force-pushed
the
filter-orig-class-attribute
branch
from
e5c4556 to
14dac45
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
(cherry picked from commit ec60616)
Merged
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1876
This change addressed a regression introduced in 8.15.0 as part of the refactor to support type hints.
The problem is in
AttrDict, which can get confused and inject an attribute named__orig_class__in the underlying dict. For example:This happens because Python adds the
__orig_class__attribute to all instances that were created with explicit generic arguments given. The logic inAttrDict.__setattr__to detect if an attribute is part of the dictionary or a real attribute of the instance does not work for__orig_class__.