support composable templates #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
new-templates
branch
5 times, most recently
from
f68aa55 to
f84a7e2
Compare
miguelgrinberg
force-pushed
the
new-templates
branch
from
f84a7e2 to
4e11d10
Compare
miguelgrinberg
force-pushed
the
new-templates
branch
from
4e11d10 to
3030014
Compare
miguelgrinberg
force-pushed
the
new-templates
branch
from
3030014 to
d177fa3
Compare
pquentin
approved these changes
Dec 10, 2024
elasticsearch_dsl/_async/index.py
Outdated
Comment on lines
159
to
161
| # TODO: should we allow pattern to be a top-level arg? | ||
| # or maybe have an IndexPattern that allows for it and have | ||
| # Document._index be that? |
There was a problem hiding this comment.
It seems to me that we should either do it or remove this comment. (The current code seems perfectly usable to me.)
There was a problem hiding this comment.
Okay, I'll remove, since these are likely from very long ago and we clearly are fine with the way this is.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* support composable templates * do not error on aiohttp warning * rename new index template to composable index template * remove old comment (cherry picked from commit a0c53db)
miguelgrinberg
added a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for composable templates as a second templating option. The two examples that use templates have been upgraded to the newer templates.