Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Expands client documentation #34

Merged
merged 11 commits into from
Oct 21, 2021

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Oct 13, 2021

Overview

This PR adds new pieces of content to the Java API Client documentation.

Elasticsearch Java API Client

@szabosteve szabosteve added 7.x v8.0.0 Area: Documentation Improvements or additions to documentation labels Oct 13, 2021
@szabosteve szabosteve changed the title [DOCS] Expands client documentation [WIP][DOCS] Expands client documentation Oct 13, 2021
@szabosteve szabosteve changed the title [WIP][DOCS] Expands client documentation [DOCS] Expands client documentation Oct 13, 2021
@szabosteve szabosteve marked this pull request as ready for review October 13, 2021 15:58
@szabosteve szabosteve requested a review from swallez October 13, 2021 16:07
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I left a comment about a missing link.

Comment on lines 18 to 19
Client that takes care of all transport-level concerns: HTTP connection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks! Addressed via 79c3854.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@szabosteve szabosteve merged commit 734ffaf into elastic:main Oct 21, 2021
@szabosteve szabosteve deleted the add.documentation branch October 21, 2021 15:50
szabosteve added a commit to szabosteve/elasticsearch-java that referenced this pull request Oct 25, 2021
[DOCS] Expands client documentation
# Conflicts:
#	docs/connecting.asciidoc
#	docs/installation.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Improvements or additions to documentation v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants