Skip to content

Commit

Permalink
Fix ECMAScript import (#2475)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshMock authored Nov 18, 2024
1 parent 6dc83cd commit 36cfacc
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 2 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [18.x, 20.x, 22.x, 23.x]
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
Expand All @@ -57,6 +57,10 @@ jobs:
run: |
npm run test:unit
- name: ECMAScript module test
run: |
npm run test:esm
license:
name: License check
runs-on: ubuntu-latest
Expand Down Expand Up @@ -110,3 +114,7 @@ jobs:
- name: Unit test
run: |
bun run test:unit-bun
- name: ECMAScript module test
run: |
bun run test:esm
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@
"main": "./index.js",
"types": "index.d.ts",
"exports": {
"require": "./index.js"
"require": "./index.js",
"import": "./index.js",
"types": "./index.d.ts"
},
"scripts": {
"test": "npm run build && npm run lint && tap",
"test:unit": "npm run build && tap",
"test:unit-bun": "bun run build && bunx tap",
"test:esm": "npm run build && cd test/esm/ && npm install && node test-import.mjs",
"test:coverage-100": "npm run build && tap --coverage --100",
"test:coverage-report": "npm run build && tap --coverage && nyc report --reporter=text-lcov > coverage.lcov",
"test:coverage-ui": "npm run build && tap --coverage --coverage-report=html",
Expand Down
7 changes: 7 additions & 0 deletions test/esm/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "esm",
"version": "1.0.0",
"dependencies": {
"@elastic/elasticsearch": "file:../.."
}
}
28 changes: 28 additions & 0 deletions test/esm/test-import.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { Client } from '@elastic/elasticsearch'

new Client({
node: 'http://localhost:9200',
auth: {
username: 'elastic',
password: 'changeme',
}
})

0 comments on commit 36cfacc

Please sign in to comment.