Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 504 error handling and update contributing guide #182

Merged
merged 1 commit into from
Feb 2, 2015
Merged

Add 504 error handling and update contributing guide #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Please write test cases to exercise your changes.
Or to skip the integration tests:

```sh
grunt test_unit
grunt unit_test
```
4. Optionally, run the browser tests. While this step is automated and simple, it can take several minutes for the tests to complete. Unless you are making changes to browser specific portions of the code you can probably let Travis run the browser tests for you.

Expand Down
6 changes: 6 additions & 0 deletions src/lib/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ _.inherits(errors.RequestTypeError, ErrorAbstract);

var statusCodes = {

/**
* GatewayTimeout
* @param {String} [msg] - An error message that will probably end up in a log.
*/
504: 'Gateway Timeout',

/**
* ServiceUnavailable
* @param {String} [msg] - An error message that will probably end up in a log.
Expand Down