Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tap artifacts #2487

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Ignore tap artifacts #2487

merged 1 commit into from
Nov 21, 2024

Conversation

JoshMock
Copy link
Member

Fixes #2483

This was referenced Nov 21, 2024
@JoshMock JoshMock merged commit 26ae260 into main Nov 21, 2024
29 checks passed
@JoshMock JoshMock deleted the drop-tap branch November 21, 2024 16:14
Copy link
Contributor

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2487-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 26ae2600585d071eb1ba9b1598a441ab02d0295c
# Push it to GitHub
git push --set-upstream origin backport-2487-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2487-to-8.15.

github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
(cherry picked from commit 26ae260)
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
(cherry picked from commit 26ae260)
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
(cherry picked from commit 26ae260)
JoshMock added a commit that referenced this pull request Nov 21, 2024
JoshMock added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is including tap files into the npm bundles intentional?
1 participant