Remove "_source_include" and "_source_exclude" from overrides (#4070)

elastic · Sep 4, 2019 · 6284623 · 6284623
1 parent 4e8a5ea
commit 6284623
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs
@@ -15,8 +15,6 @@ public class SearchOverrides : EndpointOverridesBase
 			"q", //we dont support GET searches
 			"sort",
 			"_source",
-			"_source_include",
-			"_source_exclude",
 			"_source_includes",
 			"_source_excludes",
 			"track_scores",

diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/UpdateOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/UpdateOverrides.cs
@@ -8,7 +8,6 @@ public class UpdateOverrides : EndpointOverridesBase
 		public override IEnumerable<string> SkipQueryStringParams => new[]
 		{
 			"fields",
-			"_source_include", "_source_exclude",
 			"_source_includes", "_source_excludes"
 		};
 	}

diff --git a/src/CodeGeneration/ApiGenerator/Configuration/Overrides/GlobalOverrides.cs b/src/CodeGeneration/ApiGenerator/Configuration/Overrides/GlobalOverrides.cs
@@ -39,8 +39,7 @@ public class GlobalOverrides : EndpointOverridesBase
 			"parent", //can be removed once https://github.com/elastic/elasticsearch/pull/41098 is in
 			"copy_settings", //this still needs a PR?
 			"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method
-			"timestamp",
-			"_source_include", "_source_exclude", // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in
+			"timestamp"
 		};
 	}
 }
diff --git a/src/CodeGeneration/ApiGenerator/Domain/Specification/QueryParameters.cs b/src/CodeGeneration/ApiGenerator/Domain/Specification/QueryParameters.cs
@@ -9,7 +9,7 @@ public class QueryParameters
 	{
 		private static readonly string[] FieldsParams =
 		{
-			"fields", "_source_include", "_source_exclude", "_source_includes", "_source_excludes",
+			"fields", "_source_includes", "_source_excludes",
 		};
 
 		public bool Skip { get; set; }