Add GenericProperty.Indexed to support bool? values #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds GenericProperty.Indexed to allow a bool? value to be specified for the field's "index" value, in line with other properties. Deprecate the usage of GenericProperty.Index and point users to users GenericProperty.Indexed. If a user does continue to use GenericProperty.Index however, set a value of true for FieldIndexOption.Analyzed and FieldIndexOption.NotAnalyzed, false for FieldIndexOption.No, and null for null. GenericProperty.Index will be updated to type bool? in 7.x Fixes #3103
russcam
added a commit
that referenced
this pull request
Apr 30, 2018
This commit adds GenericProperty.Indexed to allow a bool? value to be specified for the field's "index" value, in line with other properties. Deprecate the usage of GenericProperty.Index and point users to users GenericProperty.Indexed. If a user does continue to use GenericProperty.Index however, set a value of true for FieldIndexOption.Analyzed and FieldIndexOption.NotAnalyzed, false for FieldIndexOption.No, and null for null. GenericProperty.Index will be updated to type bool? in 7.x Fixes #3103 (cherry picked from commit 79caff0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
GenericProperty.Indexedto allow abool?value to be specified for the field's "index" value,in line with other properties.
Deprecate the usage of
GenericProperty.Indexand point users to usersGenericProperty.Indexed. If a user does continue to useGenericProperty.Indexhowever, set a value of
trueforFieldIndexOption.AnalyzedandFieldIndexOption.NotAnalyzed,falseforFieldIndexOption.No, andnullfornull.GenericProperty.Indexwill be updated to typebool?in 7.x in #3224Fixes #3103