Better geo_shape support #3230
Merged
Better geo_shape support #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Obsolete IgnoreUnmapped on IGeoShape This commit removes IgnoreUnmapped on IGeoShape. IgnoreUnmapped exists at the same level as _name and boost on a geo_shape query. (cherry picked from commit 1055eb2)
This commit provides better support for geo_shape queries and working with geoshapes by - condensing derived IGeoShapeQuery queries into one query - providing a fluent API experience in line with other NEST conventions - internalizing parameterless ctors on IGeoShape and passing invariants as ctor parameters Closes #3213
russcam
force-pushed
the
fix/geoshape-support
branch
from
7116755
to
a52171a
Compare
This commit allows a branch name to be passed on the command line to use when
generating documentation e.g
build docs:master
This commit puts all GeoShape query test classes into one file since they are all related to geo_shape queries. This also streamlines the generated documentation,
Mpdreamz
approved these changes
May 2, 2018
|
7eb57d1 should be ported to 6.x and 5.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides better support for geo_shape queries and working with
geoshapes by
IGeoShapeQueryqueries into one queryIGeoShapeand passing invariants as ctor parametersCloses #3213