Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Machine Learning filter APIs and detector custom rules #3632

Merged
merged 4 commits into from
Apr 1, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Mar 29, 2019

Relates: #3615

This PR adds

  • the Put, Get, Update and Delete filters APIs, required for working with ML detector custom rules
  • custom rules to machine learning detectors. The name of types used closely follows those used in Elasticsearch source.

russcam added 2 commits March 28, 2019 16:09
This commit adds the Put, Get, Update and Delete filters APIs,
required for working with ML detector custom rules
This commit adds custom rules to machine learning
detectors. The name of types used closely follows those
used in Elasticsearch source.

Relates: #3615
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a few comments

"integer" is no longer a type used within the spec
@russcam russcam merged commit 4be96d0 into 6.7 Apr 1, 2019
russcam added a commit that referenced this pull request Apr 1, 2019
* Add ML filters APIs

This commit adds the Put, Get, Update and Delete filters APIs,
required for working with ML detector custom rules

* Add ML detector custom rules

This commit adds custom rules to machine learning
detectors. The name of types used closely follows those
used in Elasticsearch source.

* Remove "integer" from API generator

"integer" is no longer a type used within the spec

Relates: #3615
russcam added a commit that referenced this pull request May 8, 2019
* Add ML filters APIs

This commit adds the Put, Get, Update and Delete filters APIs,
required for working with ML detector custom rules

* Add ML detector custom rules

This commit adds custom rules to machine learning
detectors. The name of types used closely follows those
used in Elasticsearch source.

* Remove "integer" from API generator

"integer" is no longer a type used within the spec

Relates: #3615
russcam added a commit that referenced this pull request May 9, 2019
* Add ML filters APIs

This commit adds the Put, Get, Update and Delete filters APIs,
required for working with ML detector custom rules

* Add ML detector custom rules

This commit adds custom rules to machine learning
detectors. The name of types used closely follows those
used in Elasticsearch source.

* Remove "integer" from API generator

"integer" is no longer a type used within the spec

Relates: #3615
@russcam russcam deleted the feature/ml-detector-rules branch May 10, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants