Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix places where IMemoryStreamFactory was being side stepped #3650

Merged
merged 3 commits into from
Apr 12, 2019
Merged

fix places where IMemoryStreamFactory was being side stepped #3650

merged 3 commits into from
Apr 12, 2019

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Apr 8, 2019

… and MemoryStream's were being new'ed directly

russcam
russcam approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment

src/Elasticsearch.Net/Providers/RecyclableMemoryStreamFactory.cs Outdated Show resolved Hide resolved
russcam
russcam approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit ad8ba6a into 7.x Apr 12, 2019
@Mpdreamz Mpdreamz deleted the fix/memorystreamfactory-side-stepped branch June 17, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @russcam