Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Index Lifecycle APIs #3671

Merged
merged 35 commits into from
May 8, 2019
Merged

Implement Index Lifecycle APIs #3671

merged 35 commits into from
May 8, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain commented Apr 16, 2019

Would like to discuss the Put Lifecycle API methods on the client.

@codebrain codebrain added the WIP label Apr 16, 2019
- Ack responses to use base class and interface
- LifestyleActions deserialisation
- Implement additional integration tests
Explain lifecycle
Stop ILM
Remove Policy
@codebrain codebrain self-assigned this May 6, 2019
@codebrain codebrain mentioned this pull request May 6, 2019
24 tasks
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I've left some comments about API naming and XML docs

src/Nest/XPack/Ilm/Actions/AllocateAction.cs Show resolved Hide resolved
src/Nest/XPack/Ilm/Actions/ForceMergeAction.cs Outdated Show resolved Hide resolved
src/Nest/XPack/Ilm/Actions/ForceMergeAction.cs Outdated Show resolved Hide resolved
src/Nest/XPack/Ilm/Actions/ForceMergeAction.cs Outdated Show resolved Hide resolved
src/Nest/XPack/Ilm/Actions/UnfollowAction.cs Show resolved Hide resolved
src/Nest/XPack/Ilm/GetStatus/OperationMode.cs Outdated Show resolved Hide resolved
src/Nest/XPack/Ilm/MoveToStep/IlmMoveToStepRequest.cs Outdated Show resolved Hide resolved
@codebrain codebrain merged commit 8ee42f4 into 6.7 May 8, 2019
russcam pushed a commit that referenced this pull request May 8, 2019
Implement Index Lifecycle APIs (#3671)
russcam added a commit that referenced this pull request May 9, 2019
Implement Index Lifecycle APIs (#3671)
@russcam russcam deleted the feature/ilm-apis branch May 10, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants