Security Api Key functionality #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
May 7, 2019
There was a problem hiding this comment.
LGTM 👍 I left some questions about the high level API naming, Security* which apply to the request/response types and API methods.
Security is the API spec namespace for methods, but the 6.x client does not have API namespaces. Should Security be removed, or moved to before ApiKey e.g.
SecurityCreateApiKey() -> CreateSecurityApiKey
or
SecurityCreateApiKey() -> CreateApiKey
src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs
Outdated
Show resolved
Hide resolved
src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs
Outdated
Show resolved
Hide resolved
|
I've renamed everything to drop the "Security*" prefix from the beginning, looks much better. |
…k prefix to low level dispatch calls
russcam
pushed a commit
that referenced
this pull request
May 8, 2019
russcam
added a commit
that referenced
this pull request
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.