Add doc’s sequence number + primary term to get responses #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
May 27, 2019
| @@ -33,6 +33,12 @@ public interface IGetResponse<out TDocument> : IResponse where TDocument : class | |||
|
|
|||
| [JsonProperty("_version")] | |||
| long Version { get; } | |||
|
|
|||
| [JsonProperty("_primary_term")] | |||
There was a problem hiding this comment.
should this be long? on 6.x ? Not returned on older versions.
There was a problem hiding this comment.
I've looked into this, there are other areas of the code that have implemented both properties as long and not long?...
There was a problem hiding this comment.
They are implemented as long in places where a value is always returned, and as nullable in places where a value is returned only if a request parameter is provided that indicates to return it
codebrain
added a commit
that referenced
this pull request
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: elastic/elasticsearch#36680
Backport to
masterand7.xrequires care due to naming conventions,