Add overloads of SerializeToString and SerializeToBytes #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds method overloads of SerializeToString and SerializeToBytes that accept an IMemoryStreamFactory as a non-optional parameter, and reinstates methods that do not take an IMemoryStreamFactory. This will make upgrading from 6.x to 7.x easier for those that make use of SerializeToString. Closes #3771
codebrain
approved these changes
Jun 11, 2019
Mpdreamz
reviewed
Jun 11, 2019
| @@ -23,7 +29,13 @@ public static class ElasticsearchSerializerExtensions | |||
| public static string SerializeToString<T>( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds method overloads of SerializeToString and SerializeToBytes
that accept an IMemoryStreamFactory as a non-optional parameter, and reinstates
methods that do not take an IMemoryStreamFactory. This will make upgrading from
6.x to 7.x easier for those that make use of SerializeToString.
Closes #3771