Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum on stats aggregation always returns a value #3834

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 20, 2019

Relates: elastic/elasticsearch#27193

This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.

Relates: elastic/elasticsearch#27193

This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the upstream PR too

@Mpdreamz Mpdreamz merged commit 4f64167 into 7.x Jun 20, 2019
@Mpdreamz Mpdreamz deleted the fix/elasticsearch-27193 branch June 20, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants