Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CCR Follow Info API #3927

Merged
merged 6 commits into from
Jul 16, 2019
Merged

Add CCR Follow Info API #3927

merged 6 commits into from
Jul 16, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain commented Jul 8, 2019 •
edited
Loading

Add ccr follow info API

elastic/elasticsearch#37408

@codebrain codebrain mentioned this pull request Jul 8, 2019
Closed
17 tasks
russcam
russcam suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment about the property type for TimeValue fields

src/Nest/XPack/CrossClusterReplication/Follow/FollowInfo/FollowConfig.cs Outdated Show resolved Hide resolved
src/Nest/XPack/CrossClusterReplication/Follow/FollowInfo/FollowConfig.cs Outdated Show resolved Hide resolved
@Mpdreamz
Copy link
Member

One unit test failure:

Tests.CodeStandards.Serialization.Enums.EnumsWithEnumMembersShouldBeMarkedWithStringEnumAttribute [FAIL]
Failed   Tests.CodeStandards.Serialization.Enums.EnumsWithEnumMembersShouldBeMarkedWithStringEnumAttribute
Error Message:
 Expected collection to be empty, but found {"FollowerIndexStatus"}.
Stack Trace:

russcam
russcam approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebrain codebrain changed the base branch from 7.1 to master July 16, 2019 06:01
@codebrain codebrain merged commit 8941aaf into master Jul 16, 2019
codebrain added a commit that referenced this pull request Jul 16, 2019
@codebrain
Implement CCR Follow Info API (#3927)
85640ac 
Implement CCR Follow Info API
russcam pushed a commit that referenced this pull request Jul 18, 2019
@codebrain @russcam
Implement CCR Follow Info API (#3927)
4502d9c 
Implement CCR Follow Info API
codebrain added a commit that referenced this pull request Jul 19, 2019
@codebrain
Implement CCR Follow Info API (#3927)
2578769 
Implement CCR Follow Info API
@russcam russcam deleted the feature/7.1/ccr-follow-info branch July 24, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz requested changes

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @Mpdreamz @russcam