-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to Invalidate Token API #3937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a couple of small suggestions.
Could a brief description/reference be added to the PR title, describing the change or linking to the issue?
src/Nest/XPack/Security/User/InvalidateUserAccessToken/InvalidateUserAccessTokenRequest.cs
Outdated
Show resolved
Hide resolved
src/Nest/XPack/Security/User/InvalidateUserAccessToken/InvalidateUserAccessTokenRequest.cs
Outdated
Show resolved
Hide resolved
…ateUserAccessTokenRequest.cs Co-Authored-By: Russ Cam <russ.cam@elastic.co>
…sticsearch-net into feature/7.1/invalidate-token
russcam
pushed a commit
that referenced
this pull request
Jul 15, 2019
* Implement additional fields on invalidate user token requests * Add error details to response * Update src/Nest/XPack/Security/User/InvalidateUserAccessToken/InvalidateUserAccessTokenRequest.cs * Fix inherit doc references Co-Authored-By: Russ Cam <russ.cam@elastic.co> (cherry picked from commit 47167fa)
russcam
added a commit
that referenced
this pull request
Jul 18, 2019
* Implement additional fields on invalidate user token requests * Add error details to response * Update src/Nest/XPack/Security/User/InvalidateUserAccessToken/InvalidateUserAccessTokenRequest.cs * Fix inherit doc references Co-Authored-By: Russ Cam <russ.cam@elastic.co>
codebrain
added a commit
that referenced
this pull request
Jul 19, 2019
* Implement additional fields on invalidate user token requests * Add error details to response * Update src/Nest/XPack/Security/User/InvalidateUserAccessToken/InvalidateUserAccessTokenRequest.cs * Fix inherit doc references Co-Authored-By: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance Invalidate Token API
elastic/elasticsearch#35388