Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Circle processor #4161

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Add Circle processor #4161

merged 3 commits into from
Oct 21, 2019

Conversation

codebrain
Copy link
Contributor

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just left one minor comment

@Mpdreamz
Copy link
Member

1 test failure, unrelated: #4167

@russcam russcam merged commit a1b5c7e into 7.x Oct 21, 2019
@russcam
Copy link
Contributor

russcam commented Oct 21, 2019

ported to master

russcam pushed a commit that referenced this pull request Oct 21, 2019
* Implement circle processor.
* Make parameters nullable.

(cherry picked from commit a1b5c7e)
@Mpdreamz Mpdreamz deleted the feature/7.x/circle-processor branch November 6, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants