Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments in 'update' example #2303

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix arguments in 'update' example #2303

merged 1 commit into from
Sep 22, 2023

Conversation

Grimmish
Copy link

Noticed that this example didn't match actual functionality; fixed to align with correct argument described at https://elasticsearch-py.readthedocs.io/en/v8.9.0/api.html#elasticsearch.Elasticsearch.update.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 15, 2023

💚 CLA has been signed

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. You will need to sign the CLA though.

@pquentin
Copy link
Member

@Grimmish Still interested?

@Grimmish
Copy link
Author

Yep! I thought I signed the CLA, but it didn't go through. Just submitted it again via DocuSign.

@pquentin pquentin merged commit 858c515 into elastic:8.9 Sep 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants