Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cat API example #212

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix Cat API example #212

merged 1 commit into from
Aug 21, 2024

Conversation

jeinwag
Copy link
Contributor

@jeinwag jeinwag commented Jan 17, 2023

The Cat API example in the overview of the docs does not work, since the Cat API returns plain text by default, so the deserialization into a JSON value will fail.

Explicitly telling the API to return JSON fixes this.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 17, 2023

💚 CLA has been signed

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeinwag, good catch! Can you sign the contributor agreement so that I can merge this PR?

@jeinwag
Copy link
Contributor Author

jeinwag commented Aug 21, 2024

@swallez Done.

@swallez swallez merged commit 89bedee into elastic:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants