Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark data stream stats API as private on Serverless #2678

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 5, 2024

As done by @dakrone in elastic/elasticsearch#108745. This will remove this method from the Serverless clients.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.data_streams_stats 🟢 4/4 4/4

You can validate this API yourself by using the make validate target.

@dakrone
Copy link
Member

dakrone commented Jul 5, 2024

This was actually reverted in elastic/elasticsearch#109814, so let's hold off on this until it's been re-merged.

@dakrone
Copy link
Member

dakrone commented Sep 11, 2024

The new PR for this is elastic/elasticsearch#112712, so this can be merged once that is merged (scheduled for next Thursday or Friday)

@pquentin
Copy link
Member Author

Thanks for the heads up! Subscribed. (Typically we wait for the pull request to actually be deployed to Serverless, as the clients are generated from the main branch.)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, the other change has been merged, so this LGTM now.

@pquentin
Copy link
Member Author

The change was deployed to production, merging.

@pquentin pquentin merged commit ec63077 into main Sep 25, 2024
6 checks passed
@pquentin pquentin deleted the data-stream-stats-internal branch September 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants