making range aggregation untagged union #2725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
reviewed
Jul 16, 2024
compiler/src/steps/validate-model.ts
Outdated
| @@ -610,6 +610,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma | |||
| } else if (variants.kind === 'untagged') { | |||
| if (fqn(parentName) !== '_types.query_dsl:DecayFunction' && | |||
| fqn(parentName) !== '_types.query_dsl:DistanceFeatureQuery' && | |||
| fqn(parentName) !== '_types.aggregations:AggregationRange' && | |||
There was a problem hiding this comment.
Nit: Let's keep the names in alphabetical order please :-)
| export type AggregationRange = | ||
| | UntypedAggregationRange | ||
| | NumberAggregationRange | ||
| | StringAggregationRange |
There was a problem hiding this comment.
Let's check, if we can have "term" range aggregations and if yes, rename this variant to TermAggregationRange.
We as well most likely want to have either a Date- or even a DateMath variant.
There was a problem hiding this comment.
DateRangeAggregation can be part of the union yes. so untyped | number | term | date, like range query?
There was a problem hiding this comment.
just noticed that DateRangeAggregation, like IpRangeAggregation, has its own field in the AggregationContainer (date_range). does it make sense to also add it here?
This reverts commit 1f832ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2641
draft for now because I still have to figure out if we're mapping the responses right