-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlay for deep objects in ML analysis_config, datafeed_config, and transform source #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
changed the title
Add overlay for query object in ML datafeed_config
Add overlay for deep objects in ML analysis_config and datafeed_config
Sep 18, 2024
lcawl
force-pushed
the
overlay-abbreviated
branch
from
September 18, 2024 18:57
e57cef2
to
2c60f3e
Compare
lcawl
changed the title
Add overlay for deep objects in ML analysis_config and datafeed_config
Add overlay for deep objects in ML analysis_config, datafeed_config, and source
Sep 18, 2024
lcawl
changed the title
Add overlay for deep objects in ML analysis_config, datafeed_config, and source
Add overlay for deep objects in ML analysis_config, datafeed_config, and transform source
Sep 18, 2024
szabosteve
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor suggestions, otherwise LGTM!
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
lcawl
added a commit
that referenced
this pull request
Sep 23, 2024
…and transform source (#2904) Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
lcawl
added a commit
that referenced
this pull request
Sep 24, 2024
…and transform source (#2904) Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds overlays that address the following errors that appear when deploying documents in Bump.sh:
For now I've overlaid:
query
object within theml._types:Datafeed
,ml._types:DataframeAnalyticsSource
, andtransform._types:Source
schema objectstokenizer
object withinml._types:CategorizationAnalyzerDefinition
I've replaced them with descriptions that match what we had in https://www.elastic.co/guide/en/elasticsearch/reference/current/ml-put-job.html , https://www.elastic.co/guide/en/elasticsearch/reference/current/put-dfanalytics.html, and https://www.elastic.co/guide/en/elasticsearch/reference/current/put-transform.html. However, we could potentially overlay only the a subset of objects deeper within
_types.query_dsl:QueryContainer
and_types.analysis:Tokenizer
, depending on further analysis of where they're re-used.I've also added an
x-abbreviated: true
property so that we can have an indicator of where the abbreviation occurs.Before
After