Accept any FieldValue for terms_set #2906
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
terms_set
definition to accept any FieldValue, as theterms
query already does, and as the Elasticsearch server implementation already does.This is not a breaking change at the Typescript level, as FieldValue includes
string
as one of its alternatives, but the materialization of the change may result in a breaking API change in specific language (e.g. Java) compiled clients.