-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlay for deep object in security APIs #2914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
changed the title
Add overlay for deep objects in security APIs
Add overlay for deep objects in alias and security APIs
Sep 19, 2024
lcawl
force-pushed
the
overlay-abbreviated-2
branch
from
September 19, 2024 19:02
6b543cd
to
3f32db8
Compare
szabosteve
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lcawl
force-pushed
the
overlay-abbreviated-2
branch
from
October 16, 2024 23:09
3cf954e
to
5604365
Compare
lcawl
force-pushed
the
overlay-abbreviated-2
branch
from
October 16, 2024 23:14
5604365
to
a30f952
Compare
lcawl
changed the title
Add overlay for deep objects in alias and security APIs
Add overlay for deep object in security APIs
Oct 16, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2914-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e7547bb90da03348df819aeb1812af0b16b577da
# Push it to GitHub
git push --set-upstream origin backport-2914-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
lcawl
added a commit
that referenced
this pull request
Oct 16, 2024
lcawl
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
x-model
extension for the role template query schema in the role APIs, since it is too deep to display well at this time. It also adds a link to https://www.elastic.co/guide/en/elasticsearch/reference/master/field-and-document-access-control.html#templating-role-query