Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay for deep object in security APIs #2914

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 19, 2024

This PR adds the x-model extension for the role template query schema in the role APIs, since it is too deep to display well at this time. It also adds a link to https://www.elastic.co/guide/en/elasticsearch/reference/master/field-and-document-access-control.html#templating-role-query

@lcawl lcawl added the OpenAPI label Sep 19, 2024
@lcawl lcawl changed the title Add overlay for deep objects in security APIs Add overlay for deep objects in alias and security APIs Sep 19, 2024
@lcawl lcawl marked this pull request as ready for review September 19, 2024 19:03
@lcawl lcawl marked this pull request as draft September 19, 2024 20:43
@lcawl lcawl marked this pull request as ready for review September 19, 2024 22:17
@lcawl lcawl marked this pull request as draft September 20, 2024 05:22
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl marked this pull request as ready for review October 16, 2024 23:21
@lcawl lcawl changed the title Add overlay for deep objects in alias and security APIs Add overlay for deep object in security APIs Oct 16, 2024
@lcawl lcawl merged commit e7547bb into main Oct 16, 2024
7 checks passed
@lcawl lcawl deleted the overlay-abbreviated-2 branch October 16, 2024 23:22
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2914-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e7547bb90da03348df819aeb1812af0b16b577da
# Push it to GitHub
git push --set-upstream origin backport-2914-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2914-to-8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants