Skip to content

Commit

Permalink
remove invalid todo in ShardGetService (#85921)
Browse files Browse the repository at this point in the history
668d557
added some `todo` in `ShardGetService` suggest that source might parsed
and available in the sourceLookup.
https://github.com/elastic/elasticsearch/blob/668d55758b751e848f2b82299e2c5e74af55cd12/src/main/java/org/elasticsearch/index/get/ShardGetService.java#L315
https://github.com/elastic/elasticsearch/blob/668d55758b751e848f2b82299e2c5e74af55cd12/src/main/java/org/elasticsearch/index/get/ShardGetService.java#L431
However ,`SourceLookup` in `ShardGetService` has been remove in #20158
which made these `todo` invalid.  One of them has been removed in #83152
This PR remove the left invalid `todo` in `ShardGetService`
  • Loading branch information
mushao999 authored Apr 20, 2022
1 parent ef35767 commit 445d438
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ private GetResult innerGetLoadFromStoredFields(
if (fetchSourceContext.fetchSource() == false) {
source = null;
} else if (fetchSourceContext.includes().length > 0 || fetchSourceContext.excludes().length > 0) {
// TODO: The source might be parsed and available in the sourceLookup but that one uses unordered maps so different.
// Do we care?
try {
source = XContentFieldFilter.newFieldFilter(fetchSourceContext.includes(), fetchSourceContext.excludes())
.apply(source, null);
Expand Down

0 comments on commit 445d438

Please sign in to comment.