Skip to content

Commit

Permalink
Remove "reinstall" packaging tests (#37851)
Browse files Browse the repository at this point in the history
The packaging tests currently have a test which installs elasticsearch,
removes it, modifies ownership of /etc/elasticsearch, and
reinstalls. It then checks that the /etc/elasticsearch directory has
ownership that the package expects. But the recursive change touches
files not owned by the package. In the past this worked because we did a
recursive ownership change within the package postinst. However, that
was recently removed, and thus this test no longer makes sense.
  • Loading branch information
rjernst committed Jan 25, 2019
1 parent 1964f53 commit c91dfe6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 89 deletions.
78 changes: 0 additions & 78 deletions qa/vagrant/src/test/resources/packaging/tests/90_reinstall.bats

This file was deleted.

11 changes: 0 additions & 11 deletions qa/vagrant/src/test/resources/packaging/utils/utils.bash
Original file line number Diff line number Diff line change
Expand Up @@ -228,17 +228,6 @@ assert_output() {
echo "$output" | grep -E "$1"
}

assert_recursive_ownership() {
local directory=$1
local user=$2
local group=$3

realuser=$(find $directory -printf "%u\n" | sort | uniq)
[ "$realuser" = "$user" ]
realgroup=$(find $directory -printf "%g\n" | sort | uniq)
[ "$realgroup" = "$group" ]
}

# Deletes everything before running a test file
clean_before_test() {

Expand Down

0 comments on commit c91dfe6

Please sign in to comment.