Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] EsqlSpecIT test {ints.WarningWithFromSource} failing #100163

Closed
mark-vieira opened this issue Oct 2, 2023 · 12 comments · Fixed by #103031
Closed

[CI] EsqlSpecIT test {ints.WarningWithFromSource} failing #100163

mark-vieira opened this issue Oct 2, 2023 · 12 comments · Fixed by #103031
Assignees
@bpintea
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI

Comments

@mark-vieira
Copy link
Contributor

Build scan:
https://gradle-enterprise.elastic.co/s/e2qarzt72fo2u/tests/:x-pack:plugin:esql:qa:server:multi-node:javaRestTest/org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT/test%20%7Bints.WarningWithFromSource%7D
Reproduction line:

./gradlew ':x-pack:plugin:esql:qa:server:multi-node:javaRestTest' --tests "org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT" -Dtests.method="test {ints.WarningWithFromSource}" -Dtests.seed=B0AC1F2AF6CEF42E -Dtests.locale=es-US -Dtests.timezone=Pacific/Noumea -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
No

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT&tests.test=test%20%7Bints.WarningWithFromSource%7D
Failure excerpt:

java.lang.AssertionError: Expected a list containing
0: "Line 1:65: evaluation of [to_int(x)] failed, treating result as null. Only first 20 failures recorded."
1: expected "Line 1:65: org.elasticsearch.xpack.ql.QlIllegalArgumentException: [100010000000] out of [integer] range" but was "Line 1:65: org.elasticsearch.xpack.ql.QlIllegalArgumentException: [100730000000] out of [integer] range"

  at __randomizedtesting.SeedInfo.seed([B0AC1F2AF6CEF42E:38F820F0583299D6]:0)
  at org.elasticsearch.test.MapMatcher.assertMap(MapMatcher.java:82)
  at org.elasticsearch.test.MapMatcher.assertMap(MapMatcher.java:65)
  at org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.performRequest(RestEsqlTestCase.java:498)
  at org.elasticsearch.xpack.esql.qa.rest.RestEsqlTestCase.runEsql(RestEsqlTestCase.java:447)
  at org.elasticsearch.xpack.esql.qa.rest.EsqlSpecTestCase.doTest(EsqlSpecTestCase.java:102)
  at org.elasticsearch.xpack.esql.qa.rest.EsqlSpecTestCase.test(EsqlSpecTestCase.java:94)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@mark-vieira mark-vieira added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Oct 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@mark-vieira
Copy link
Contributor Author

Both this an multipleWarnings are newly added and seem to be failing a lot so I've muted them both in 81cecfb.

@costin costin assigned costin and bpintea and unassigned costin Oct 2, 2023
@bpintea
Copy link
Contributor

bpintea commented Oct 9, 2023

Fixed in #100539.

@bpintea bpintea closed this as completed Oct 9, 2023
@bpintea bpintea mentioned this issue Oct 9, 2023
Closed
@ldematte
Copy link
Contributor

Failed again for me today during a CI build on main.
Build scan: https://gradle-enterprise.elastic.co/s/rcxeixpz6r5ki/tests/task/:x-pack:plugin:esql:qa:server:single-node:javaRestTest/details/org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT/test%20%7Bints.WarningWithFromSource%7D?top-execution=1

@ldematte ldematte reopened this Nov 14, 2023
@nik9000
Copy link
Member

nik9000 commented Nov 15, 2023

@bpintea could you investigate this one?

@dnhatn
Copy link
Member

dnhatn commented Nov 15, 2023

Another instance: https://gradle-enterprise.elastic.co/s/w4woe5qhz72om/

@kkrik-es
Copy link
Contributor

Happened again: https://gradle-enterprise.elastic.co/s/3djzij34rxx4s

@bpintea
Copy link
Contributor

bpintea commented Nov 16, 2023

The new failures aren't the same as those that prompted opening this issue:

  • old failure:
java.lang.AssertionError: Expected a list containing
0: "Line 1:65: evaluation of [to_int(x)] failed, treating result as null. Only first 20 failures recorded."
1: expected "Line 1:65: org.elasticsearch.xpack.ql.QlIllegalArgumentException: [100010000000] out of [integer] range" but was "Line 1:65: org.elasticsearch.xpack.ql.QlIllegalArgumentException: [100730000000] out of [integer] range"
  • new failures:
org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT > test {ints.WarningWithFromSource#[skip:-8.11.99, reason:ql exceptions were updated in 8.12]} FAILED
    java.lang.AssertionError: Expected a list containing
    0: expected "Line 1:89: evaluation of [to_int(x)] failed, treating result as null. Only first 20 failures recorded." but was <missing>
    1: expected "Line 1:89: org.elasticsearch.xpack.ql.InvalidArgumentException: [100010000000] out of [integer] range" but was <missing>

@bpintea bpintea mentioned this issue Nov 16, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Nov 16, 2023
@bpintea
Mute failing EsqlSpecIT ints.WarningWithFromSource (#102303)
ac3f23d 
Mute failing EsqlSpecIT test `ints.WarningWithFromSource`.

Related: #100163
@bpintea bpintea mentioned this issue Dec 5, 2023
Closed
@bpintea
Copy link
Contributor

bpintea commented Dec 5, 2023 •
edited by dnhatn
Loading

@dnhatn, is there any work left for #99927?
There's this issue and a new similar one (besides some other build failure) which have the same manifestation as #98719. I'm not positive that these have be the same cause, but it's likely.

@dnhatn
Copy link
Member

dnhatn commented Dec 5, 2023

@bpintea I have a theory, but haven't been able to reproduce it. I will have another look at the response headers today.

@dnhatn
Copy link
Member

dnhatn commented Dec 6, 2023

@bpintea @nik9000 I can reproduce and I think I understand the issue. I will work on the fix shortly.

@dnhatn dnhatn mentioned this issue Dec 6, 2023
Merged
dnhatn added a commit that referenced this issue Dec 6, 2023
@dnhatn
Collect warnings in compute service (#103031)
be1277a 
We have implemented #99927 in DriverRunner. However, we also need to 
implement this in ComputeService, where we spawn multiple requests to
avoid losing response headers.

Relates #99927

Closes #100163
Closes #102982
Closes #102871
Closes #103028
dnhatn added a commit to dnhatn/elasticsearch that referenced this issue Dec 6, 2023
@dnhatn
Collect warnings in compute service (elastic#103031)
048b1a0 
We have implemented elastic#99927 in DriverRunner. However, we also need to
implement this in ComputeService, where we spawn multiple requests to
avoid losing response headers.

Relates elastic#99927

Closes elastic#100163
Closes elastic#102982
Closes elastic#102871
Closes elastic#103028
@dnhatn dnhatn mentioned this issue Dec 6, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Dec 6, 2023
@dnhatn
Collect warnings in compute service (#103031) (#103079)
bdd2b42 
We have implemented #99927 in DriverRunner. However, we also need to
implement this in ComputeService, where we spawn multiple requests to
avoid losing response headers.

Relates #99927

Closes #100163
Closes #102982
Closes #102871
Closes #103028
bpintea added a commit to bpintea/elasticsearch that referenced this issue Dec 18, 2023
@bpintea
Re-enable tests after warnings collection correction
6eb7c71 
Re-enable a couple of warning header checking tests that have been
disabled, but mistakenly without linking the issue (elastic#100163), which lead
to them being kept disabled also after the fix (elastic#103031).
@bpintea bpintea mentioned this issue Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpintea bpintea

Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collect warnings in compute service dnhatn/elasticsearch
8 participants
@costin @nik9000 @bpintea @ldematte @mark-vieira @dnhatn @elasticsearchmachine @kkrik-es