[CI] EsqlSpecIT test {ints.MultipleWarnings} failing #100164
Assignees
Labels
:Analytics/ES|QL
AKA ESQL
Team:QL (Deprecated)
Meta label for query languages team
>test-failure
Triaged test failures from CI
Comments
costin
added
:Analytics/ES|QL
|
Pinging @elastic/es-ql (Team:QL) |
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
@bpintea Sure, I will have a look. |
|
Response headers can be lost when a driver is yielded and rescheduled. I've opened #100724. |
dnhatn
added a commit
that referenced
this issue
Oct 18, 2023
Today, we have a hierarchy of tasks in ESQL designed to leverage the task framework for reporting status and cancellation. ```mermaid flowchart RESTLayer -->| EsqlQueryRequest indices:data/read/esql | ComputeService ComputeService -->| DriverRequest indices:data/read/esql/compute | Driver ComputeService -->| DataNodeRequest indices:data/read/esql/data | DataNode DataNode -->| DriverRequest indices:data/read/esql/compute | Driver Driver -->| LookupRequest indices:data/read/esql/lookup | EnrichLookupService ``` The primary issue here is that `DriverRequest` is neither `IndicesRequest` nor `CompositeIndicesRequest`. Consequently, the Driver is executed within the context of the system user, leading to access indices with the system user. To address this issue, this PR makes `DriverRequest` a `CompositeIndicesRequest` and ensures that the Driver executes within the user's context. With this fix we can now properly capture the response headers when a Driver is yielded and rescheduled. Relates #100707 Relates #99646 Relates #99926 Closes #100164
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this issue
Oct 18, 2023
Today, we have a hierarchy of tasks in ESQL designed to leverage the task framework for reporting status and cancellation. ```mermaid flowchart RESTLayer -->| EsqlQueryRequest indices:data/read/esql | ComputeService ComputeService -->| DriverRequest indices:data/read/esql/compute | Driver ComputeService -->| DataNodeRequest indices:data/read/esql/data | DataNode DataNode -->| DriverRequest indices:data/read/esql/compute | Driver Driver -->| LookupRequest indices:data/read/esql/lookup | EnrichLookupService ``` The primary issue here is that `DriverRequest` is neither `IndicesRequest` nor `CompositeIndicesRequest`. Consequently, the Driver is executed within the context of the system user, leading to access indices with the system user. To address this issue, this PR makes `DriverRequest` a `CompositeIndicesRequest` and ensures that the Driver executes within the user's context. With this fix we can now properly capture the response headers when a Driver is yielded and rescheduled. Relates elastic#100707 Relates elastic#99646 Relates elastic#99926 Closes elastic#100164
elasticsearchmachine
pushed a commit
that referenced
this issue
Oct 18, 2023
Today, we have a hierarchy of tasks in ESQL designed to leverage the task framework for reporting status and cancellation. ```mermaid flowchart RESTLayer -->| EsqlQueryRequest indices:data/read/esql | ComputeService ComputeService -->| DriverRequest indices:data/read/esql/compute | Driver ComputeService -->| DataNodeRequest indices:data/read/esql/data | DataNode DataNode -->| DriverRequest indices:data/read/esql/compute | Driver Driver -->| LookupRequest indices:data/read/esql/lookup | EnrichLookupService ``` The primary issue here is that `DriverRequest` is neither `IndicesRequest` nor `CompositeIndicesRequest`. Consequently, the Driver is executed within the context of the system user, leading to access indices with the system user. To address this issue, this PR makes `DriverRequest` a `CompositeIndicesRequest` and ensures that the Driver executes within the user's context. With this fix we can now properly capture the response headers when a Driver is yielded and rescheduled. Relates #100707 Relates #99646 Relates #99926 Closes #100164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Build scan:
https://gradle-enterprise.elastic.co/s/juee6bgkgo6na/tests/:x-pack:plugin:esql:qa:server:multi-node:javaRestTest/org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT/test%20%7Bints.MultipleWarnings%7D
Reproduction line:
Applicable branches:
main
Reproduces locally?:
Didn't try
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT&tests.test=test%20%7Bints.MultipleWarnings%7D
Failure excerpt:
The text was updated successfully, but these errors were encountered: