Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we fail engine immediately after a delete fails? #33256

Closed
dnhatn opened this issue Aug 30, 2018 · 1 comment · Fixed by #40117
Closed

Should we fail engine immediately after a delete fails? #33256

dnhatn opened this issue Aug 30, 2018 · 1 comment · Fixed by #40117
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard.

Comments

@dnhatn
Copy link
Member

dnhatn commented Aug 30, 2018 •
edited
Loading

This is a spin-off of #33217 (comment).

Today when a delete operation on a primary fails, we won't immediately fails that shard but "replace" that delete by a NoOp. While this approach sounds correct, its benefit is questionable. What can we recover after a delete fails? If nothing, should we just fail a shard immediately?

Let's revisit this approach.
@dnhatn dnhatn added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. team-discuss labels Aug 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn mentioned this issue Aug 30, 2018
Merged
@dnhatn dnhatn mentioned this issue Mar 15, 2019
Merged
dnhatn added a commit that referenced this issue Mar 19, 2019
@dnhatn
Always fail engine if delete operation fails (#40117)
a520cc5 
Unlike index operations which can fail at the document level to
analyzing errors, delete operations should never fail at the document
level whether soft-deletes is enabled or not. With this change, we will
always fail the engine if we fail to apply a delete operation to Lucene.

Closes #33256
dnhatn added a commit that referenced this issue Mar 19, 2019
@dnhatn
Always fail engine if delete operation fails (#40117)
a13b4bc 
Unlike index operations which can fail at the document level to
analyzing errors, delete operations should never fail at the document
level whether soft-deletes is enabled or not. With this change, we will
always fail the engine if we fail to apply a delete operation to Lucene.

Closes #33256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always fail engine if delete operation fails dnhatn/elasticsearch
2 participants
@dnhatn @elasticmachine