-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCR] Paused follower does not display in follower stats #37127
Comments
Pinging @elastic/es-distributed |
So the reason that no stats are returned for paused follower indices, is that there are no shard follow tasks when index following is paused and the follow stats api is based on returning stats entries for shard follow tasks. I think the best way for the UI is to figure out all the follower indices by checking whether the index setting |
@martijnvg Thanks for the insight. While using cluster state api would work, the user could potentially have a large number of indices and we will have to look through each index's Open for more discussion on this. Let me know if a solution might be feasible for 6.7, otherwise for 6.7 we will investigate the cluster state api route and/or adjust UI scope. |
@jen-huang I thought a bit more about this and I think we can change the follow stats api to also include follower indices that are paused. These indices would then we returned without any stats entries and would look like this:
Here the @jasontedor @dnhatn Do you think adding follower indices with empty shard entries is a good idea here in order to include paused follower indices in the stats api? This way the UI will then only need to check one api display stats for ccr follower indices (instead of the workaround mentioned above). |
@martijnvg Yes, having zero shard stats would work for the UI 😄 |
@martijnvg Does having 0 shards means that it is paused? What if ES would provide then a "status" field in that case
|
Yes, having 0 follow shard stats entries in the response means a follow index is paused.
I think we could add a status field to make the the status of a follower index more clear. |
Hi @martijnvg, @sebelga has started work on providing the follower index advanced settings UI at the time of creation: elastic/kibana#28267 The advanced settings include If the user has specified any of these settings, we would like to display that later on in the UI for their reference. However, we don't have any way to read out their settings after creation. Would it be possible to modify the stats api to return this information as well? |
This should be visible in the cluster state under
I think it makes sense to add the used index follow parameters as part of the follow stats api. Then there is a single place all information about for ccr index following can be read. |
After thinking more about this, I think we should not include the follow index parameters / settings inside of the follow stats api. The follow stats api returns very dynamic information about the replication processes that ccr manages for each follow index shard; which is a different kind of information than the follow index parameters, what the status is of a follower index or which indices are follower indices. What I think we should do instead, is add another api that returns that kind of information. I think we should add a follow info api. Which returns all the follower indices and for each follower index returns the status (active or paused) and index follow parameters. Then we can leave the follow stats api as is. The structure of the response of the follow info api would then look like this:
|
@martijnvg The separate list of follower indices API you mention will be very useful for the user IMO |
Agreed @martijnvg . A separate API would be better for listing follower indices. Cheers! |
@martijnvg ++ to that suggestion - a separate API would be perfect and fills a large gap. |
++ to separate API. It would be useful for index management UI as well. |
This api returns all follower indices and per follower index the provided parameters at put follow / resume follow time and whether index following is paused or active. Closes elastic#37127
* Add ccr follow info api This api returns all follower indices and per follower index the provided parameters at put follow / resume follow time and whether index following is paused or active. Closes #37127 * iter * [DOCS] Edits the get follower info API * [DOCS] Fixes link to remote cluster * [DOCS] Clarifies descriptions for configured parameters
This api returns all follower indices and per follower index the provided parameters at put follow / resume follow time and whether index following is paused or active. Closes #37127
I created a follower index,
kibana_sample_data_logs
.Then I paused the follower index using:
Then I attempted to retrieve the stats of the follower index using both:
and
Neither one lists
kibana_sample_data_logs
as part ofindices
array. I resumed the follower using:and then the stats API showed the correct information.
For CCR UI, we need the stats API to:
paused
flag.This will make it so that we can give the user the correct option in the UI (whether to resume or pause follower index based on its status).
cc @elastic/es-ui
The text was updated successfully, but these errors were encountered: