Deserialize timeZone with DateUtils in RangeQueryBuilder

[pgomulka]

as spotted in this review #38415 (comment)
DateUtil should be used when serialising/deserializing timezones to allow deprecation logging

[elasticmachine]

Pinging @elastic/es-core-infra

[gwbrown]

Looks like the place that actually needs to be changed to use DateUtils.dateTimeZoneToZoneId is:

elasticsearch/server/src/main/java/org/elasticsearch/index/query/RangeQueryBuilder.java

Line 95 in 95582da

timeZone = in.readOptionalZoneId();

[pedrochamberlain]

Hello, is this issue still open? I'd like to give it a shot. This would be my first issue.

[LeeTgk]

Hi. is this issue still open? I would like to try it as my first issue. 🤨:mag:

[pgomulka]

@LeeTgk sure, it is still open. Feel free to send PR

[sojuforme]

I attempted to fix this issue. I created a pull request and tried to make the commit as clear as possible.

[timothy-choi]

Hello is this issue still open? I would like to fix this issue.

[happyCupcake]

@gwbrown @williamrandolph @pgomulka I am new to open source and to elasticsearch and with some guidance I can help. I reviewed all comments and previous PR's.

Here, the call in.readOptionalZoneId() needs to be replaced with DateUtils.dateTimeZoneToZoneId(DateTimeZone) , but its not clear to me how because dateTimeZoneToZoneId takes as input timezone and returns zone id but the current code is reading zoneId and storing as timezone.

Does the stream contain a zoneId or timezone ? If its zoneId, then we dont need to call dateTimeZoneToZoneId, but if the stream contains timezone, then I need to convert string timezone to DateTimeZone before calling dateTimeZoneToZoneId

Any guidance will help :-)

public RangeQueryBuilder(StreamInput in) throws IOException {
..

timeZone = in.readOptionalZoneId();

[ayushrawat99]

HI I am new and want to give it a shot. Can I pick this up ?

[ldematte]

Not needed anymore since #40647