Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] MonitoringBulkRequestTests.testAddRequestContent #39980

Closed
andyb-elastic opened this issue Mar 12, 2019 · 3 comments · Fixed by #39997
Closed

[CI] MonitoringBulkRequestTests.testAddRequestContent #39980

andyb-elastic opened this issue Mar 12, 2019 · 3 comments · Fixed by #39997
Assignees
@jakelandis
Labels
:Data Management/Monitoring >test-failure Triaged test failures from CI

Comments

@andyb-elastic
Copy link
Contributor

This reproduces, may have been caused by #39888

On master

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/872/console

On 7.x

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+matrix-java-periodic/ES_BUILD_JAVA=openjdk12,ES_RUNTIME_JAVA=java11,nodes=immutable&&linux&&docker/68/console

build-periodic-7.x-68.txt.zip

  1> [2019-03-12T02:03:16,742][INFO ][o.e.x.m.a.MonitoringBulkRequestTests] [testAddRequestContent] before test                                                                                
  1> [2019-03-12T02:03:16,755][INFO ][o.e.x.m.a.MonitoringBulkRequestTests] [testAddRequestContent] after test                                                                                 
FAILURE 0.03s J7 | MonitoringBulkRequestTests.testAddRequestContent <<< FAILURES!              
   > Throwable #1: java.lang.AssertionError:   
   > Expected: "qxHU"                          
   >      but: was "_doc"                      
   >    at __randomizedtesting.SeedInfo.seed([3E7752DEB7B82078:6BF9E9DF11928659]:0)            
   >    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)                        
   >    at org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests.testAddRequestContent(MonitoringBulkRequestTests.java:136)                                                     
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)      
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)                                                                                    
   >    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)                                                                            
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:566)                          
   >    at java.base/java.lang.Thread.run(Thread.java:834)

The seed is all that's needed, the compiler version doesn't matter

./gradlew :x-pack:plugin:monitoring:unitTest -Dtests.seed=3E7752DEB7B82078 -Dtests.class=org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests -Dtests.method="testAddRequestContent" -Dtests.security.manager=true -Dtests.locale=wo -Dtests.timezone=Chile/EasterIsland -Dcompiler.java=12 -Druntime.java=11

It looks like it's still trying to use custom types

elasticsearch/x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/action/MonitoringBulkRequestTests.java

Line 136 in bec0a19

assertThat(bulkDoc.getType(), equalTo(types[count] != null ? types[count] : defaultType));

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Mar 13, 2019
@jakelandis
Fix test which still uses default type
68e5fe4 
org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests#testAddRequestContent
can still randomly use a defaultType for monitoring. The defaultType
support has been removed as of PR elastic#39888. Prior to its's removal it
would default the type if one is not specified. The _type on the monitoring
bulk end point is currently required, though it is not used as the final index type
(which defaultType would have).

Closes elastic#39980
@jakelandis jakelandis mentioned this issue Mar 13, 2019
Merged
jakelandis added a commit that referenced this issue Mar 13, 2019
@jakelandis
Fix test which still uses default type (#39997)
ee91531 
org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests#testAddRequestContent
can still randomly use a defaultType for monitoring. The defaultType
support has been removed as of PR #39888. Prior to its's removal it
would default the type if one is not specified. The _type on the monitoring
bulk end point is currently required, though it is not used as the final index type
(which defaultType would have).

Closes #39980
@cbuescher
Copy link
Member

@jakelandis this still seems to fail on 7.0 and 7.x, is the fix on those branches as well?
e.g.
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.0+matrix-java-periodic/ES_BUILD_JAVA=openjdk12,ES_RUNTIME_JAVA=zulu11,nodes=immutable&&linux&&docker/72/console

@jakelandis
Copy link
Contributor

@cbuescher - I am working on the back ports. Just got a passing 7.x and will have 7.0 a bit later today.

jakelandis added a commit that referenced this issue Mar 14, 2019
@jakelandis
Fix test which still uses default type (#39997)
e9fa776 
org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests#testAddRequestContent
can still randomly use a defaultType for monitoring. The defaultType
support has been removed as of PR #39888. Prior to its's removal it
would default the type if one is not specified. The _type on the monitoring
bulk end point is currently required, though it is not used as the final index type
(which defaultType would have).

Closes #39980
jakelandis added a commit that referenced this issue Mar 14, 2019
@jakelandis
Fix test which still uses default type (#39997)
a07d76a 
org.elasticsearch.xpack.monitoring.action.MonitoringBulkRequestTests#testAddRequestContent
can still randomly use a defaultType for monitoring. The defaultType
support has been removed as of PR #39888. Prior to its's removal it
would default the type if one is not specified. The _type on the monitoring
bulk end point is currently required, though it is not used as the final index type
(which defaultType would have).

Closes #39980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelandis jakelandis

Labels
:Data Management/Monitoring >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test which still uses default type jakelandis/elasticsearch
4 participants
@jakelandis @cbuescher @elasticmachine @andyb-elastic