Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] MultiMatchQueryBuilderTests#testToQuery fails #41847

Closed
danielmitterdorfer opened this issue May 6, 2019 · 0 comments · Fixed by #41854
Closed

[CI] MultiMatchQueryBuilderTests#testToQuery fails #41847

danielmitterdorfer opened this issue May 6, 2019 · 0 comments · Fixed by #41854
Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v6.8.0

Comments

@danielmitterdorfer
Copy link
Member

Note: There is an already closed issue for the same test (#36598) but as this one fails for a different reason I'm raising a new issue instead

   > Throwable #1: java.lang.AssertionError: query was marked as not cacheable in the context but this test indicates it should be cacheable: {
   >   "multi_match" : {
   >     "query" : "NOwGPnuTXe",
   >     "fields" : [ ],
   >     "type" : "best_fields",
   >     "operator" : "AND",
   >     "analyzer" : "standard",
   >     "slop" : 0,
   >     "prefix_length" : 0,
   >     "max_expansions" : 5,
   >     "lenient" : true,
   >     "cutoff_frequency" : 0.24390244,
   >     "zero_terms_query" : "NONE",
   >     "auto_generate_synonyms_phrase_query" : true,
   >     "fuzzy_transpositions" : true,
   >     "boost" : 0.1
   >   }
   > }
  • Reproduction line:
./gradlew :server:unitTest \
  -Dtests.seed=D5624C9FE68BCB38 \
  -Dtests.class=org.elasticsearch.index.query.MultiMatchQueryBuilderTests \
  -Dtests.method="testToQuery" \
  -Dtests.security.manager=true \
  -Dtests.locale=ms \
  -Dtests.timezone=Asia/Tehran \
  -Dcompiler.java=12 \
  -Druntime.java=8

This reproduction line reliably reproduces locally as well.

@danielmitterdorfer danielmitterdorfer added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v6.8.0 labels May 6, 2019
jimczi added a commit to jimczi/elasticsearch that referenced this issue May 6, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes elastic#41847
jimczi added a commit that referenced this issue May 6, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes #41847
jimczi added a commit that referenced this issue May 6, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes #41847
jimczi added a commit that referenced this issue May 6, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes #41847
jimczi added a commit that referenced this issue May 6, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes #41847
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this issue May 27, 2019
Full text queries that start with now are not cacheable if they target a date field.
However we assume in the query builder tests that all queries are cacheable and this assumption
fails when the random generated query string starts with "now". This fails twice in several years
since the probability that a random string starts with "now" is low but this commit ensures that
 isCacheable is correctly checked for full text queries that fall into this edge case.

 Closes elastic#41847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI v6.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant