Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for "max_shingle_size" parameter #51774

Closed
sebelga opened this issue Jan 21, 2020 · 4 comments · Fixed by #53480
Closed

Update documentation for "max_shingle_size" parameter #51774

sebelga opened this issue Jan 21, 2020 · 4 comments · Fixed by #53480
Assignees
@jrodewig
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@sebelga
Copy link
Contributor

sebelga commented Jan 21, 2020 •
edited by jrodewig
Loading

While building the Kibana UI for the mappings editor search_as_you_type type, CJ and Gail improved the description text (see comment) to explain what the max_shingle_size parameter is for.

We should port that effort to the Elasticsearch docs and help users that only go to the docs and don't use the UI.

Screen Shot 2020-01-21 at 11 49 41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jrodewig jrodewig transferred this issue from elastic/kibana Jan 31, 2020
@jrodewig jrodewig added the >docs General docs changes label Jan 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig added the :Search/Search Search-related issues that do not fall into other categories label Jan 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@jrodewig jrodewig self-assigned this Mar 3, 2020
@jrodewig jrodewig mentioned this issue Mar 12, 2020
Merged
@jrodewig jrodewig added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Search/Search Search-related issues that do not fall into other categories labels Mar 12, 2020
jrodewig added a commit that referenced this issue Mar 13, 2020
@jrodewig
[DOCS] Clarify max_shingle_size parm def (#53480)
febe7af 
Rewrites the `search_as_you_type` field datatype's `max_shingle_size`
mapping parameter to improve clarity and better communicate trade-offs
regarding index size.

Relates to [elastic/kibana#55161][0].

Closes #51774.

[0]: elastic/kibana#55161 (comment)
jrodewig added a commit that referenced this issue Mar 13, 2020
@jrodewig
[DOCS] Clarify max_shingle_size parm def (#53480)
1e31031 
Rewrites the `search_as_you_type` field datatype's `max_shingle_size`
mapping parameter to improve clarity and better communicate trade-offs
regarding index size.

Relates to [elastic/kibana#55161][0].

Closes #51774.

[0]: elastic/kibana#55161 (comment)
jrodewig added a commit that referenced this issue Mar 13, 2020
@jrodewig
[DOCS] Clarify max_shingle_size parm def (#53480)
0e495a3 
Rewrites the `search_as_you_type` field datatype's `max_shingle_size`
mapping parameter to improve clarity and better communicate trade-offs
regarding index size.

Relates to [elastic/kibana#55161][0].

Closes #51774.

[0]: elastic/kibana#55161 (comment)
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrodewig jrodewig

Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOCS] Clarify max_shingle_size parm def
5 participants
@javanna @sebelga @elasticmachine @gchaps @jrodewig