Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproducible failure in ChildrenToParentAggregatorTests.testParentChildTerms #60980

Closed
jaymode opened this issue Aug 11, 2020 · 3 comments · Fixed by #60991
Closed

Reproducible failure in ChildrenToParentAggregatorTests.testParentChildTerms #60980

jaymode opened this issue Aug 11, 2020 · 3 comments · Fixed by #60991
Assignees
@nik9000
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@jaymode
Copy link
Member

jaymode commented Aug 11, 2020

Build scan: https://gradle-enterprise.elastic.co/s/hrcgyap7ink5y/tests/:modules:parent-join:test/org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests/testParentChildTerms#1

Repro line:

./gradlew ':modules:parent-join:test' --tests "org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests.testParentChildTerms" -Dtests.seed=5A1275B4C2BB46F7 -Dtests.security.manager=true -Dtests.locale=hr-HR -Dtests.timezone=America/Pangnirtung -Druntime.java=8

Reproduces locally?: Yes

Applicable branches: 7.x

Failure excerpt:

org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests > testParentChildTerms FAILED
    java.lang.AssertionError: expected:<5> but was:<40>
        at __randomizedtesting.SeedInfo.seed([5A1275B4C2BB46F7:6A8FFC1BFB980E92]:0)
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests.lambda$testParentChildTerms$5(ChildrenToParentAggregatorTests.java:188)
        at org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests.testCaseTerms(ChildrenToParentAggregatorTests.java:318)
        at org.elasticsearch.join.aggregations.ChildrenToParentAggregatorTests.testParentChildTerms(ChildrenToParentAggregatorTests.java:176)
@jaymode jaymode added :Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI labels Aug 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 11, 2020
@jaymode jaymode mentioned this issue Aug 11, 2020
Merged
@dnhatn
Copy link
Member

dnhatn commented Aug 11, 2020

Another instance: https://gradle-enterprise.elastic.co/s/bkjfalmxnsix2

@nik9000 nik9000 self-assigned this Aug 11, 2020
dnhatn added a commit that referenced this issue Aug 11, 2020
@dnhatn
Mute ChildrenToParentAggregatorTests
766177f 
Tracked at #60980
dnhatn added a commit that referenced this issue Aug 11, 2020
@dnhatn
Mute ChildrenToParentAggregatorTests
4bdf283 
Tracked at #60980
@nik9000
Copy link
Member

nik9000 commented Aug 11, 2020

This bisects to #60683. So it'll be the test assuming that the result wasn't fully reduced. I'll dig.

@nik9000 nik9000 mentioned this issue Aug 11, 2020
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Aug 11, 2020
@nik9000
Fix the parent join aggregator test case
d331afb 
The test was putting parent and child documents into different segments
which is unrealistic and was causing errors.

Closes elastic#60980
nik9000 added a commit that referenced this issue Aug 11, 2020
@nik9000
Fix the parent join aggregator test case (#60991)
dc1b969 
The test was putting parent and child documents into different segments
which is unrealistic and was causing errors.

Closes #60980
nik9000 added a commit that referenced this issue Aug 11, 2020
@nik9000
Fix the parent join aggregator test case (#60991)
664ba0a 
The test was putting parent and child documents into different segments
which is unrealistic and was causing errors.

Closes #60980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the parent join aggregator test case nik9000/elasticsearch
4 participants
@nik9000 @jaymode @dnhatn @elasticmachine