Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] StatsAggregatorTests.testSummationAccuracy failure #61132

Closed
henningandersen opened this issue Aug 14, 2020 · 2 comments
Closed

[CI] StatsAggregatorTests.testSummationAccuracy failure #61132

henningandersen opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v7.10.0 v8.0.0-alpha1

Comments

@henningandersen
Copy link
Contributor

Build scan:

https://gradle-enterprise.elastic.co/s/voerxtqazihqa

Repro line:

./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.metrics.StatsAggregatorTests.testSummationAccuracy"   -Dtests.seed=4772739B26F93342   -Dtests.security.manager=true   -Dtests.locale=ms-MY   -Dtests.timezone=Europe/Skopje   -Druntime.java=8

Reproduces locally?:
Yes, using above and in IntelliJ, using same seed.

Applicable branches:

Failure history:
It has failed once in master and once in 7.x in the last couple of days.

Failure excerpt:

java.lang.AssertionError: expected:<0.9> but was:<0.8999999999999999>
        at __randomizedtesting.SeedInfo.seed([4772739B26F93342:1EBB81430D65ED31]:0)
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:553)
        at org.junit.Assert.assertEquals(Assert.java:683)
        at org.elasticsearch.search.aggregations.metrics.StatsAggregatorTests.lambda$verifySummationOfDoubles$6(StatsAggregatorTests.java:192)
        at org.elasticsearch.search.aggregations.metrics.StatsAggregatorTests.testCase(StatsAggregatorTests.java:438)
        at org.elasticsearch.search.aggregations.metrics.StatsAggregatorTests.verifySummationOfDoubles(StatsAggregatorTests.java:183)
        at org.elasticsearch.search.aggregations.metrics.StatsAggregatorTests.testSummationAccuracy(StatsAggregatorTests.java:143)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 14, 2020
@nik9000 nik9000 self-assigned this Aug 18, 2020
@nik9000
Copy link
Member

nik9000 commented Aug 18, 2020

I have a fix for this locally and I'll push tomorrow when I can be around after pushing.

nik9000 added a commit that referenced this issue Aug 19, 2020
With #60683 we stopped forcing aggregating all docs using a single
Aggregator which made some of our accuracy assumptions about the stats
aggregator incorrect. This adds a test that does the forcing and asserts
the old accuracy and adds a test without the forcing with much looser
accuracy guarantees.

Closes #61132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

No branches or pull requests

4 participants